[OTR-dev] Missing opdata in callback for otrl_message_sending when using fragmentation/injection

[Chris Ballinger]

Ah thanks, didn't catch that. Any word on moving the official repo from
Sourceforge to GitHub? There's a couple mirrors on GitHub but it would be
helpful to have an officially blessed one.

Also is there an ETA for the next point release, 4.0.1? It looks like
there's some somewhat-important changes in the master branch, like the
constant-time memory comparison functions.


On Fri, May 9, 2014 at 12:28 PM, David Goulet <dgoulet at ev0ke.net> wrote:

> This has been fixed in upstream libotr:
>
>         commit d748757e581b74e7298df155ad49174cb914102b
>
> David
>
> On 09 May (12:22:51), Chris Ballinger wrote:
> > fragment:
> >
> >     if (fragPolicy == OTRL_FRAGMENT_SEND_SKIP ) {
> >
> > /* Do not fragment/inject. Default behaviour of libotr3.2.0 */
> >
> > return err;
> >
> >     } else {
> >
> > /* Fragment and send according to policy */
> >
> > if (!err && messagep && *messagep) {
> >
> >     if (context) {
> >
> > err = fragment_and_send(ops, NULL, context, *messagep,
> >
> > fragPolicy, messagep);
> >
> >     }
> >
> > }
> >
> > return err;
> >
> >     }
> >
> >
> >
> > When setting opdata to non-NULL via the otrl_message_sending function,
> > the inject_message_cb callback will have a null opdata because on line
> 444
> > of message.c NULL is passed into fragment_and_send instead of opdata.
>
> > _______________________________________________
> > OTR-dev mailing list
> > OTR-dev at lists.cypherpunks.ca
> > http://lists.cypherpunks.ca/mailman/listinfo/otr-dev
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.cypherpunks.ca/pipermail/otr-dev/attachments/20140509/25c5f35c/attachment.html>