[OTR-dev] Missing opdata in callback for otrl_message_sending when using fragmentation/injection

David Goulet dgoulet at ev0ke.net
Fri May 9 15:28:45 EDT 2014


This has been fixed in upstream libotr:

	commit d748757e581b74e7298df155ad49174cb914102b

David

On 09 May (12:22:51), Chris Ballinger wrote:
> fragment:
> 
>     if (fragPolicy == OTRL_FRAGMENT_SEND_SKIP ) {
> 
> /* Do not fragment/inject. Default behaviour of libotr3.2.0 */
> 
> return err;
> 
>     } else {
> 
> /* Fragment and send according to policy */
> 
> if (!err && messagep && *messagep) {
> 
>     if (context) {
> 
> err = fragment_and_send(ops, NULL, context, *messagep,
> 
> fragPolicy, messagep);
> 
>     }
> 
> }
> 
> return err;
> 
>     }
> 
> 
> 
> When setting opdata to non-NULL via the otrl_message_sending function,
> the inject_message_cb callback will have a null opdata because on line 444
> of message.c NULL is passed into fragment_and_send instead of opdata.

> _______________________________________________
> OTR-dev mailing list
> OTR-dev at lists.cypherpunks.ca
> http://lists.cypherpunks.ca/mailman/listinfo/otr-dev

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 603 bytes
Desc: Digital signature
URL: <http://lists.cypherpunks.ca/pipermail/otr-dev/attachments/20140509/ed3b332d/attachment.pgp>


More information about the OTR-dev mailing list