[OTR-dev] Missing opdata in callback for otrl_message_sending when using fragmentation/injection

David Goulet dgoulet at ev0ke.net
Fri May 9 16:12:32 EDT 2014


On 09 May (13:05:27), Chris Ballinger wrote:
> Ah thanks, didn't catch that. Any word on moving the official repo from
> Sourceforge to GitHub? There's a couple mirrors on GitHub but it would be
> helpful to have an officially blessed one.

The upstream libotr can be found here:

https://bugs.otr.im/projects/libotr

Git - git://git.otr.im/libotr.git

This is automatically mirrored to this Github page:

https://github.com/off-the-record/libotr

All bugs from the Sourceforge page has been moved to bugs.otr.im also.

> 
> Also is there an ETA for the next point release, 4.0.1? It looks like
> there's some somewhat-important changes in the master branch, like the
> constant-time memory comparison functions.

No idea, it's up to Ian for that. There is a bunch of bugs also that
have been submitted on the mailing list some days ago.

Cheers!
David

> 
> 
> On Fri, May 9, 2014 at 12:28 PM, David Goulet <dgoulet at ev0ke.net> wrote:
> 
> > This has been fixed in upstream libotr:
> >
> >         commit d748757e581b74e7298df155ad49174cb914102b
> >
> > David
> >
> > On 09 May (12:22:51), Chris Ballinger wrote:
> > > fragment:
> > >
> > >     if (fragPolicy == OTRL_FRAGMENT_SEND_SKIP ) {
> > >
> > > /* Do not fragment/inject. Default behaviour of libotr3.2.0 */
> > >
> > > return err;
> > >
> > >     } else {
> > >
> > > /* Fragment and send according to policy */
> > >
> > > if (!err && messagep && *messagep) {
> > >
> > >     if (context) {
> > >
> > > err = fragment_and_send(ops, NULL, context, *messagep,
> > >
> > > fragPolicy, messagep);
> > >
> > >     }
> > >
> > > }
> > >
> > > return err;
> > >
> > >     }
> > >
> > >
> > >
> > > When setting opdata to non-NULL via the otrl_message_sending function,
> > > the inject_message_cb callback will have a null opdata because on line
> > 444
> > > of message.c NULL is passed into fragment_and_send instead of opdata.
> >
> > > _______________________________________________
> > > OTR-dev mailing list
> > > OTR-dev at lists.cypherpunks.ca
> > > http://lists.cypherpunks.ca/mailman/listinfo/otr-dev
> >
> >
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 603 bytes
Desc: Digital signature
URL: <http://lists.cypherpunks.ca/pipermail/otr-dev/attachments/20140509/c8095b49/attachment.pgp>


More information about the OTR-dev mailing list