[OTR-dev] Pidgin-otr end conversation

[Ian Goldberg]

On Wed, Nov 07, 2012 at 04:36:10PM -0500, David Goulet wrote:
> Hi,
> 
> I'm wondering why pidgin-otr is not notifying the peer when ending a
> private conversation which seems to be recommended by using
> "otrl_message_disconnect()".
> 
> I noticed that with irssi-otr <--> piding-otr IRC.
> 
> It's not a critical issue at all but just asking if there is a reason
> behind this behavior.
> 
> Thanks a lot everyone!
> David

Hmm.  When I choose the "End private conversation" menu item, the
notification is definitely being sent.  It happens in otr-plugin.c line
1019:

/* Disconnect a context, sending a notice to the other side, if
 * appropriate. */
void otrg_plugin_disconnect(ConnContext *context)
{
    otrl_message_disconnect(otrg_plugin_userstate, &ui_ops, NULL,
            context->accountname, context->protocol, context->username,
            context->their_instance);
}


[This is version 4.0, but I don't recall that being different in 3.x.]

Is this function not being called when you do it?

   - Ian