[OTR-dev] Bug (with fix) in proto.h, lilbotr 3.0.0

[Ian Goldberg]

On Sun, Nov 20, 2005 at 01:06:36PM -0600, Evan Schoenberg wrote:
> At proto.h:43 we have
> 
> #define OTRL_POLICY_ALLOW_V1			0x01
> #define OTRL_POLICY_ALLOW_V2			0x02
> #define OTRL_POLICY_REQUIRE_ENCRYPTION		0x04
> #define OTRL_POLICY_SEND_WHITESPACE_TAG		0x08
> #define OTRL_POLICY_WHITESPACE_START_AKE	0x08
> #define OTRL_POLICY_ERROR_START_AKE		0x10
> 
> Note that SEND_WHITESPACE_TAG and WHITESPACE_START_AKE have the same  
> value.  This is incorrect; the correct definition should be:
> #define OTRL_POLICY_ALLOW_V1			0x01
> #define OTRL_POLICY_ALLOW_V2			0x02
> #define OTRL_POLICY_REQUIRE_ENCRYPTION		0x04
> #define OTRL_POLICY_SEND_WHITESPACE_TAG		0x08
> #define OTRL_POLICY_WHITESPACE_START_AKE	0x10
> #define OTRL_POLICY_ERROR_START_AKE		0x12

Good catch, but the last value should be 0x20, not 0x12.

I've checked in the fix to CVS.

Feel free to use the fixed version (0x10, 0x20) in Adium; it won't cause
incompatibility with other clients or anything.  It just so happens that
that bug will never be exposed in gaim-otr or otrproxy, so I won't rush
out a new release of libotr.

Thanks!

   - Ian