[OTR-dev] otrl_message_sending to recipient in finished state

Martin Milata b42-ml at srck.net
Wed Apr 2 11:36:36 EDT 2014


When calling otrl_message_sending(..., OTRL_FRAGMENT_SEND_ALL, ...) to
recipient that is in finished state, the inject_message callback is
called with an empty string. The empty string is also returned in the
messagep pointer. (message.c:423 and on)

This seems like a bug to me. Returning "" in messagep can be interpreted
as 'libotr consumed the message, do not send anything' by the caller,
but injecting it as well seems wrong.

What do you think? I'll follow with a proposed patch.

Thanks,
Martin



More information about the OTR-dev mailing list