[OTR-dev] [libotr PATCH] Missing opdata when sending message fragments

Jacob Appelbaum jacob at appelbaum.net
Sun Jan 27 18:49:35 EST 2013


David Goulet:
> Hi,
> 
> I've attached a patch to this email that fixes a problem we've been
> having in irssi-otr which is that the opdata parameter is always NULL
> for the inject_message callback with fragments.
> 
> (FYI, git format-patch was used for the patch).
> 


Thanks, I've merged this into a branch (ioerror/pending-patches) for Ian
to review.

I've tested this patch by talking with a third party client
(xmpp-client) and a patched libotr client using bitlbee and another with
xmpp-client/irssi. It appears to improve things as before it was
applied, I wasn't able to start an OTR session with the other client and
stay in sync.

Could those who are impacted by this bug go into some details on their
clients, how they were broken and how this patch fixed things? It would
be good to have this in writing somewhere.

All the best,
Jacob




More information about the OTR-dev mailing list