[OTR-dev] Active fingerprint context pointer possible issue

[David Goulet]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Hi everyone,

I came across an unexpected behavior that can be due to my bad
understanding or a potential bug so I need help on this one.

The Fingerprint struct contains this:

	struct context *context;  /* The context to which we belong */

Of what I can understand, for a given context pointer (ConnContext
*ctx), this is suppose to be equal:

	ctx == ctx->active_fingerprint->context

I found out that this is not exactly true. In the "gone_secure"
callback, the context is passed as an argument but the above
supposition is not true i.e. the active_fingerprint->context is NOT
the same as the argument context but still a valid ConnContext pointer.

The issue here is if someone is trying to look the OtrlMessageState
using the active fingerprint context, it's set to
OTRL_MSGSTATE_PLAINTEXT but the gone_secure context is of course set
to encrypted.

So, am I missing something here ?

I can confirm this with the pidgin-otr plugin and the code I'm doing
as well.

Thanks a lot people!
David
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)

iQEcBAEBCgAGBQJQrDtOAAoJEELoaioR9I02Kt4IAMoL0V7+YPLAc4n3rOzIQupY
Xusqpm6brppARQ+41+7zW3Y7FeX5B4hv1btc4aNINg7pcQu0/44Iso5pxEWhoyya
1Vzi6/vA8P4Js03hvnR8lbCvFKgMxIPv11kk2etYlBnJMxil2vu1i9MqFkRUGR8E
MQLzOdp5TWp7iXof0nxusbkLrbpWMl9qVWQWCY6vJuUyCM+1gzZwMptbBIeIu6OL
AA6LPNKm1PockRHYHGAFnvP1qc0rjUl0UN9kshMYcU6Nhwh6mItJ7KYJ/SDOUsWR
bb8oSbHF9IQsHuXUq8difqcEuE6NjT+ND5LVUORmnSZjqtwsCwk/Pgtw+qMRG2k=
=rM5i
-----END PGP SIGNATURE-----