[OTR-dev] libotr/pidgin-otr 4.0 beta

[Ian Goldberg]

On Thu, May 03, 2012 at 01:42:34AM -0400, Paul Wouters wrote:
> On Wed, 2 May 2012, Rob Smits wrote:
> 
> >I've just pushed a beta of libotr and pidgin-otr 4.0 into a new
> >sourceforge git. This was delayed as we decided to separate the
> >repositories into:
> >git://otr.git.sourceforge.net/gitroot/otr/libotr
> >git://otr.git.sourceforge.net/gitroot/otr/pidgin-otr
> 
> awesome! First quick notes before falling asleep:
> 
> configure: WARNING:
> ***
> *** The config script /usr/bin/libgcrypt-config was
> *** built for x86_64-redhat-linux-gnu and thus may not match the
> *** used host x86_64-unknown-linux-gnu.
> *** You may want to use the configure option --with-libgcrypt-prefix
> *** to specify a matching config script.
> ***

Isn't this a problem with your build of libgcrypt?  Or are we missing
something in the configure.ac file?

> and:
> 
> message.c: In function 'otrl_message_sending':
> message.c:266:30: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
> message.c:359:30: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
> message.c:383:29: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
> message.c: In function 'go_encrypted':
> message.c:457:20: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
> message.c: In function 'maybe_resend':
> message.c:637:21: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
> message.c: In function 'message_malformed':
> message.c:798:19: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
> message.c: In function 'otrl_message_receiving':
> message.c:924:29: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
> message.c:984:32: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
> message.c:1248:33: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
> message.c:1253:31: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
> message.c:1277:28: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
> message.c:1283:28: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
> message.c:1590:31: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
> message.c:1623:32: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
> message.c:1700:31: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
> message.c:1768:27: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
> message.c:1782:26: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]

Good call.  Many if not all of these are because NULL is being cast to a
gcry_error_t, which is indeed wrong.  It should instead be 0, or perhaps
even gcry_error(GPG_ERR_NO_ERROR).

Thanks,

   - Ian