[OTR-dev] Is otrl_message_receiving returning 1 erroneously?

[Chris Ballinger]

When I initiate an encrypted conversation between ChatSecure and
Adium, and then cancel the OTR session in Adium, ChatSecure receives
an OTR message that I assume is telling it that the conversation is
now no longer secure (or at least that Adium canceled encryption...
otrl_message_receiving returns 1 for this message). However it seems
that this message isn't being processed properly on my end because all
plaintext that goes into the otrl_message_receiving function after
that message returns "1".

Here is the specific line where I call otrl_message_receiving:
https://github.com/chrisballinger/Off-the-Record-iOS/blob/master/Off%20the%20Record/OTRCodec.m#L308

Do I need to do something else to detect when to go into the
"finished" state? I had assumed that the callback function
gone_insecure_cb would be called when this was needed.

On Tue, Jul 24, 2012 at 8:54 AM, Ian Goldberg <ian at cypherpunks.ca> wrote:
> On Mon, Jul 23, 2012 at 08:08:12PM -0700, Chris Ballinger wrote:
>> I'm not sure if this is caused by my flawed implementation of libotr
>> in ChatSecure, but it seems that otrl_message_receiving is returning 1
>> when I'm expecting a 0. Users have mentioned that they are missing
>> messages sometimes and I haven't been able to reproduce that behavior
>> until I found this bug.
>>
>> When a conversation is encrypted between ChatSecure and Adium, then
>> encryption is canceled in Adium, any further messages between the two
>> clients will be ignored by both clients. Is there something I'm
>> missing? I did notice that gone_insecure_cb is never called either.
>
> In this case, the ChatSecure side should go into "FINISHED" state.
>
>> Relevant code is here:
>>
>> https://github.com/chrisballinger/Off-the-Record-iOS/blob/master/Off%20the%20Record/OTRCodec.m
>
> I'm not sure what this code is showing.  Can you say under what
> circumstance otrl_message_receiving is returning 1 when you expect it to
> return 0?
>
> Thanks,
>
>    - Ian
> _______________________________________________
> OTR-dev mailing list
> OTR-dev at lists.cypherpunks.ca
> http://lists.cypherpunks.ca/mailman/listinfo/otr-dev