[OTR-dev] 4.0.0-rc3 ready to roll. Please try it out!

[Thibaut VARENE]

On Tue, Aug 28, 2012 at 5:27 PM, Ian Goldberg <ian at cypherpunks.ca> wrote:
> On Tue, Aug 28, 2012 at 01:34:11PM +0200, Thibaut VARENE wrote:
>> On Tue, Aug 28, 2012 at 2:24 AM, Ian Goldberg <ian at cypherpunks.ca> wrote:
>>
>> > Indeed, otrl_init(ver_major, ver_minor, ver_sub) calls exit(1) if the
>> > passed version numbers are incompatible with the library's actual
>> > version.
>> >
>> > Seeing as how it's intended to be called from this macro:
>> >
>> > #define OTRL_INIT do { \
>> >         otrl_init(OTRL_VERSION_MAJOR, OTRL_VERSION_MINOR, OTRL_VERSION_SUB); \
>> >     } while(0)
>> >
>> > I suppose we could change otrl_init to return an error code, and change
>> > the *macro* to call exit() upon otrl_init returning an error.  Although
>> > technically the ABI would change, the API wouldn't.
>>
>> As long as the macro itself isn't used in the library, this should indeed work.
>>
>> > I will consider this for inclusion before release.
>> >
>> > Thanks for the note!
>>
>> You're welcome!
>
> Thibaut,
>
> Can you apply this patch and see if it cleans things up?  If it looks
> good, I'll include it for 4.0.0.

Looks good and fixes the warning.

Thanks

-- 
Thibaut VARENE
http://www.parisc-linux.org/~varenet/