[OTR-dev] Gaim 2.0 Update

[Andrew Rodland]

On Friday 20 January 2006 10:17, Ian Goldberg wrote:
> On Wed, Jan 18, 2006 at 01:55:46PM -0500, Andrew Rodland wrote:
> > [snipped patch to bring gaim-otr 3 in line with new gaim 2.0 api]
> This can't be right.  The type of the second parameter to
> gaim_menu_action_new isn't the same as the type of the second parameter
> to gaim_blist_node_action_new.  The latter should be a
> void (*callback)(GaimBlistNode *, gpointer), which otr_options_cb is,
> but gaim_menu_action_new takes a GaimCallback, which is a
> void(*callback)(void) there instead.
>
> But looking through the gaim code, it seems that callback is actually
> called with arguments, so I guess just a typecast to (GaimCallback) in
> front of the second parameter is in order.
>
Yeah, that's pretty strange. I didn't dig too deeply into it; I just noticed 
that with my patch, the plugin compiles and the menu works, despite the 
pointer cast warning. Certainly I don't mind if someone does it "right", just 
providing the heads-up.

Andrew