<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
<head>
<meta content="text/html; charset=UTF-8" http-equiv="Content-Type">
</head>
<body bgcolor="#ffffff" text="#000000">
I have been analysed the <a href="http://scan.coverity.com/">coverity
scan</a> of Fedora libotr-3.2.0-6 package and they have been found
following problems:<br>
<br>
<br>
/src/auth.c:385, 416, 523 - Constant expression result:
"privkey->pubkey_type >> 16" is 0 regardless of the values
of its operands<br>
<br>
/src/serial.h:67 - Suspicious implicit sign extension: "bufp[0]"
with type "unsigned char" (8 bits, unsigned) is promoted in
"(bufp[0] << 24) | (bufp[1] << 16) | (bufp[2] <<
8) | bufp[3]" to type "int" (32 bits, signed), then sign-extended to
type "unsigned long" (64 bits, unsigned). If "(bufp[0] << 24)
| (bufp[1] << 16) | (bufp[2] << 8) | bufp[3]" is greater
than 0x7FFFFFFF, the upper bits of the result will all be 1.<br>
<br>
/toolkit/otr_readforge.c:112 - Allocating insufficient memory for
the terminating null of the string.<br>
<br>
/src/proto.c:783 - Potential resource leak of variable newfrag in
else statement. <br>
<br>
/src/context.c:322, /src/privkey.c:622 - Suspicious while condition.<br>
<br>
<br>
Please check mentioned issues and if you are interested on whole
coverity scan report, it is possible to send it to you. <br>
<br>
Michal Luscon<br>
</body>
</html>