[OTR-dev] otrl_base64_otr_decode() function...

Paul Wouters paul at cypherpunks.ca
Thu Jul 19 11:37:47 EDT 2012


On Thu, 19 Jul 2012, Ian Goldberg wrote:

> How's this for a proposed patch?  [Paul, I think this addresses your
> "magic numbers" concern as well.]

It does, though I would have written:

> +    /* Skip over the "?OTR:" */
> +    otrtag += 5;
> +    msglen -= 5;

 	otrtag += sizeof("?OTR:")
 	msglen -= sizeof("?OTR:")

Then you don't even need the comment :)

Paul



More information about the OTR-dev mailing list