[OTR-dev] Bug in libotr-3.1 / 3.2: no herthbeat message is send

Marti Raudsepp marti at juffo.org
Fri Sep 12 12:28:24 EDT 2008


Bump. Still no official response from OTR developers?

On Fri, Jul 25, 2008 at 7:32 PM, Georg Sievers <georgsievers at gmx.net> wrote:
> Hallo,
>
> my name is Georg Sievers and I' m just working on a diploma thesis at the university of applied sciences TFH, Berlin, Germany, which deals with possible usecases for OTR/libotr beyond Instant Messaging.
>
> I belive I found a remarkable bug in libotr.
> In message.c, funktion "otrl_message_receiving" the field "edata.ignore_message" is initialised with "-1" (Line 747, libotr-3.2).
>
> In Line 1088 a check for "edata.ignore_message == 0" is performed, which will always evaluate to false, preventing the following  hearthbeat-sending code from beeing executed. So no heartbeat messages are ever send.
> A quick fix should be changing "edata.ignore_message == 0" to "edata.ignore_message != 1" (line 1088).
> Wathsoever, I don't feel to comfortable with having "ignore_message" set to an initale state "-1" at all. As far as I understood the  code, their doesn't seem to be a good reason for having a three-state flag at this point.
>
> I could offer to deliver a patch for this issue but first wanted to ask if there is some reason I have missed for doing it the way it is done.
>
>
> - Georg Sievers



More information about the OTR-dev mailing list