From evan.s at dreskin.net Fri Dec 22 16:04:46 2006 From: evan.s at dreskin.net (Evan Schoenberg) Date: Fri, 22 Dec 2006 16:04:46 -0500 Subject: [OTR-dev] Patch for account display name Message-ID: <00F46C22-6B5B-467D-BE3C-CEB644B0056E@dreskin.net> This patch is better than what I proposed in my previous email. It adds a ui_op for account_display_name to mirror protocol_name. Works great for me. -------------- next part -------------- A non-text attachment was scrubbed... Name: account_display_name_op.diff Type: application/octet-stream Size: 2120 bytes Desc: not available URL: -------------- next part -------------- Cheers, Evan -------------- next part -------------- A non-text attachment was scrubbed... Name: PGP.sig Type: application/pgp-signature Size: 186 bytes Desc: This is a digitally signed message part URL: From ian at cypherpunks.ca Fri Dec 22 16:39:45 2006 From: ian at cypherpunks.ca (Ian Goldberg) Date: Fri, 22 Dec 2006 16:39:45 -0500 Subject: [OTR-dev] Patch for account display name In-Reply-To: <00F46C22-6B5B-467D-BE3C-CEB644B0056E@dreskin.net> References: <00F46C22-6B5B-467D-BE3C-CEB644B0056E@dreskin.net> Message-ID: <20061222213945.GC13546@yoink.cs.uwaterloo.ca> On Fri, Dec 22, 2006 at 04:04:46PM -0500, Evan Schoenberg wrote: > This patch is better than what I proposed in my previous email. It > adds a ui_op for account_display_name to mirror protocol_name. Works > great for me. I didn't see a previous mail about this. But this looks plausible. I'll wait until after the holidays to apply and test it and stuff, though. What is the function you're passing in there for Adium X? Is gaim likely to use the same function? If so, it should probably go in the UI-independent part of gaim-otr. - Ian From evan.s at dreskin.net Fri Dec 22 16:58:30 2006 From: evan.s at dreskin.net (Evan Schoenberg) Date: Fri, 22 Dec 2006 16:58:30 -0500 Subject: [OTR-dev] Patch for account display name In-Reply-To: <20061222213945.GC13546@yoink.cs.uwaterloo.ca> References: <00F46C22-6B5B-467D-BE3C-CEB644B0056E@dreskin.net> <20061222213945.GC13546@yoink.cs.uwaterloo.ca> Message-ID: On Dec 22, 2006, at 4:39 PM, Ian Goldberg wrote: > I didn't see a previous mail about this. But this looks plausible. > I'll wait until after the holidays to apply and test it and stuff, > though. I'm not sure what happened to it. Here it is again: In libotr, contexts are often referred to be their account name and protocol, such as: format = "?OTR Error: You sent encrypted " "data to %s, who wasn't expecting it."; buf = malloc(strlen(format) + strlen(context->accountname) - 1); if (buf) { sprintf(buf, format, context->accountname); accountname and protocol are intended to be how to associate the context with a particular messaging account in the client. However, to make that association, since a client can have multiple accounts with the same accountname and protocol, I use accountname to store a unique identifier for the account (a number). Obviously, this results in error messages which are nonsense: OTR Error: You sent encrypted data to 5, who wasn't expecting it. > What is the function you're passing in there for Adium X? Is gaim > likely to use the same function? If so, it should probably go in the > UI-independent part of gaim-otr. I'm not sure what gaim would use in terms of uniquely identifying an account; certainly gaim does support having multiple accounts with the same name on the same protocol. Cheers, Evan -------------- next part -------------- An HTML attachment was scrubbed... URL: -------------- next part -------------- A non-text attachment was scrubbed... Name: PGP.sig Type: application/pgp-signature Size: 186 bytes Desc: This is a digitally signed message part URL: