[OTR-dev] Core/UI Split of gaim-otr-1.0.3

[Ian Goldberg]

On Fri, Jan 21, 2005 at 03:33:24PM -0600, Evan Schoenberg wrote:
> I think I love you? :D 
> 
> That looks awesome.  verbal and I are going to work on hooking that up 
> this weekend... I'll let you know if I run into any snags or questions. 
> 
> Two comments:  
> 
> 1) Would it be possible to automate the #define USING_GTK like so? 
> 
> #ifdef GTK_MAJOR_VERSION 
> #define USING_GTK 
> #endif 

But GTK_MAJOR_VERSION isn't defined unless you #include <gtk/something.h>
which you won't want to do unless USING_GTK is defined.

> 2) The #define GAIM_PLUGINS at the top of otr-plugin.c seems like it 
> could instead be a -DGAIM_PLUGINS in the makefile... as having it in 
> the .c file forces dynamic compilation even if building statically, 
> whereas in the makefile it would only do its thing when building via 
> make (when of course you want to create a .so file). 

That's reasonable.  In fact, probably both GAIM_PLUGINS and USING_GTK
should be in the Makefile.

Feel free to do that along with whatever else you need to do to get it
to work nicely for you, and post the patches when you're done.

> Actual code comments (or just laudations, since this looks really nice 
> and clean, thanks so much for all your hard work!) will follow once 
> I've played with implementation. 

Great.  Looking forward to seeing OTR natively supported in Adium X. :-)

Thanks,

   - Ian