[OTR-dev] Core/UI Split of gaim-otr-1.0.3

[Evan Schoenberg]

I think I love you? :D

That looks awesome.  verbal and I are going to work on hooking that up 
this weekend... I'll let you know if I run into any snags or questions.

Two comments:

1) Would it be possible to automate the #define USING_GTK like so?

#ifdef GTK_MAJOR_VERSION
#define USING_GTK
#endif

2) The #define GAIM_PLUGINS at the top of otr-plugin.c seems like it 
could instead be a -DGAIM_PLUGINS in the makefile... as having it in 
the .c file forces dynamic compilation even if building statically, 
whereas in the makefile it would only do its thing when building via 
make (when of course you want to create a .so file).

Actual code comments (or just laudations, since this looks really nice 
and clean, thanks so much for all your hard work!) will follow once 
I've played with implementation.

-Evan

On Jan 21, 2005, at 2:29 PM, Ian Goldberg wrote:

> On Fri, Jan 21, 2005 at 12:01:32PM -0600, Evan Schoenberg wrote:
>>
>> On Jan 21, 2005, at 11:15 AM, Ian Goldberg wrote:
>>>
>>> I think I see what you're saying.  What should be done about the
>>> GAIM_GTK_PLUGIN_TYPE in otr-plugin.c?  What "portably" goes there?
>>>
>> Good question.  gaim-otr will be the first significant (in terms of 
>> use
>> and in terms of size) Gaim plugin which I'm aware of which has as good
>> as core/UI split as Gaim itself soon will, if we can pull it off
>> (that's ignoring the protocol plugins such as meanwhile).  As such, I
>> don't think there's an established way to handle it.
>
> OK, then to boldly go... :-)
>
> Tell me what you think of this:
>
> http://www.cypherpunks.ca/otr/gaim-otr-cvs-latest.tar.gz
>
>    - Ian
> _______________________________________________
> OTR-dev mailing list
> OTR-dev at lists.cypherpunks.ca
> http://lists.cypherpunks.ca/mailman/listinfo/otr-dev
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: text/enriched
Size: 2083 bytes
Desc: not available
URL: <http://lists.cypherpunks.ca/pipermail/otr-dev/attachments/20050121/ab2db585/attachment.bin>